shell: nushell integration scripts by sim590 · Pull Request #4630 · junegunn/fzf

sim590 · 2025-12-09T03:36:58Z

Keybindings alt_c, ctrl_r and ctrl_t
Completion functions:
- base implementation for ** completion
- extra completion functionalities for programs such as:
  - pass
  - ssh, scp, sftp, telnet
  - kill
  - cd, pushd, rmdir

Closes: #4122

Fixes some path issues. There are still some other things to fix

Pass~[1] is a command line password storage utility. Possible queries are deduced from the file GPG hierarchy under ~/.password-store. [1]: https://www.passwordstore.org/

…sure parameter

Not sure why it doesn't work in this context, but if those are not removed, the completion process doesn't substitute the selected value to '**'.

fix typo shell/key-bindinds.nu → shell/key-bindings.nu

Copilot

Pull request overview

Adds first-class Nushell integration to fzf, including keybindings, **<TAB> fuzzy completion via Nushell’s external completer mechanism, installation/uninstallation support, and CI/test coverage to prevent regressions.

Changes:

Add fzf --nushell flag that prints Nushell integration scripts (keybindings + completion)
Add Nushell install/uninstall handling (autoload fzf.nu) and update docs
Add Nushell integration tests + Linux CI dependency install for nushell

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`main.go`	Embeds and prints Nushell integration scripts when `--nushell` is used
`src/options.go`	Adds `--nushell` option parsing and `Options.Nushell` flag
`shell/key-bindings.nu`	Implements CTRL-T / CTRL-R / ALT-C bindings for Nushell
`shell/completion.nu`	Implements `**` completion via Nushell external completer + command-specific completers
`install`	Adds Nushell to supported shells and generates autoload `fzf.nu`
`uninstall`	Removes Nushell autoload file during uninstall
`README.md`	Documents Nushell integration setup and limitations
`test/lib/common.rb`	Adds Nushell shell harness + tmux prep behavior
`test/test_shell_integration.rb`	Adds Nushell-specific integration tests (bindings + completion smoke test)
`.github/workflows/linux.yml`	Installs nushell in CI to run Nushell tests
`typos.toml`	Adds `Slq` to allowed words (for pacman `-Slq`)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sim590 · 2026-04-22T15:12:08Z

+  # Assuming standard ps output where PID is the second column
+  $selected_line | lines | each { $in | from ssv --noheaders | get 0.column1 } | to text


This is a false positive. from ssv --noheaders assigns generic column names: column0 = USER, column1 = PID, column2 = PPID, etc. So get 0.column1 correctly extracts the PID. The comment on the line above documents this.

Replace the confusing 'run this in your regular shell' comment with a pure Nushell command using 'save -f'.

The note references fzf 0.48.0 which only introduced --bash, --zsh, and --fish. The --nushell flag will be available in a later release.

Use 'recent versions of fzf' instead of a specific version number as suggested by junegunn. Also add mkdir before save to handle the case where the autoload directory does not exist yet.

junegunn · 2026-04-23T07:34:35Z

+  def test_alt_c_command
+    set_var('FZF_ALT_C_COMMAND', 'echo /tmp')
+
+    tmux.prepare
+    tmux.send_keys 'cd /', :Enter
+
+    tmux.prepare
+    tmux.send_keys :Escape, :c
+    tmux.until { |lines| assert_equal 1, lines.match_count }
+    tmux.send_keys :Enter
+
+    tmux.prepare
+    tmux.send_keys 'pwd', :Enter
+    tmux.until { |lines| assert_equal '/tmp', lines[-1] }
+  end


Same here. Except for :pwd and 'pwd' which should make no difference.

Please review these test cases if redefinitions are necessary.

Same — removed the redundant redefinition.

Please review the other tests as well to see if we can minimize code duplication.

Done — also removed test_ctrl_r (identical to TestShell). The remaining overrides now have comments explaining why they differ:

test_ctrl_t_unicode: uses ^echo (external command) since Nushell's builtin echo outputs structured data

test_file_completion: Nushell-specific, tests single-selection only (the external completer replaces the token rather than appending)

test_ctrl_r_abort: only tests with foo — single/double quotes cause issues in Nushell's line editor

Nushell-specific, tests single-selection only (the external completer replaces the token rather than appending)

Can you elaborate? We missed the multi-selection bug because of the skipping, so I'd like to keep the test if possible.

Good point. The test now covers multi-selection (Tab+Tab with 2 files), single selection, and hidden files. The previous override only tested single selection, which is how the multi-selection bug slipped through. Fixed in 4ec77b9.

junegunn · 2026-04-23T07:45:36Z

Let me just randomly post issues I noticed in the comments.

~/github/fzf> pass **Error executing data_gen closure. Closure code: closure_635. Actual error: {msg: No matches found for Expand("~/.password-store/**/*.gpg"), debug: Generic(GenericError { code: "nu::shell::error", error: "No matches found for Expand(\"~/.password-store/**/*.gpg\")", msg: "Pattern, file or folder not found", site: Span(Span[165878..165904]), help: Some("no matches found"), inner: [], source: None }), raw: Generic(GenericError { code: "nu::shell::error", error: "No matches found for Expand(\"~/.password-store/**/*.gpg\")", msg: "Pattern, file or folder not found", site: Span(Span[165878..165904]), help: Some("no matches found"), inner: [], source: None }), rendered: Error: nu::shell::error

                                              × No matches found for Expand("~/.password-store/**/*.gpg")
                                                                                                              ╭─[/Users/***/Library/Application Support/nushell/autoload/fzf.nu:528:8]
                                                                              527 │   let passwordstore_files_gen_closure = {||
                528 │     ls ~/.password-store/**/*.gpg | get name | each {$in | str replace -r '^.*?\.password-store/(.*).gpg' '${1}' }
                             ·        ─────────────┬────────────
                                                                     ·                     ╰── Pattern, file or folder not found
                 529 │   }
                               ╰────
                                      help: no matches found
                                                            , json: {"msg":"No matches found for Expand(\"~/.password-store/**/*.gpg\")","labels":[{"text":"Pattern, file or folder not found","span":{"start":165878,"end":165904}}],"code":"nu::shell::error","url":null,"help":"no matches found","inner":[]}}

junegunn · 2026-04-23T07:50:48Z

Fuzzy completion does not respect --tmux option in my $FZF_DEFAULT_OPTS. CTRL-T does.

export FZF_DEFAULT_OPTS='--tmux 90%,70%'

junegunn · 2026-04-23T10:38:14Z

Multi-selection (tab) in fuzzy completion doesn't work properly.

~/github/fzf> vim .editorconfig
::: .gitignore
::: .goreleaser.yml

It works for ^kill.

Wrap the ls glob in a try/catch so that pass completion returns an empty list instead of a verbose error when ~/.password-store does not exist.

When multiple files are selected with Tab in fzf, join them with spaces so the completer returns a single result instead of separate candidates displayed with ::: separators.

Options from FZF_DEFAULT_OPTS are already parsed and passed as CLI arguments. Without clearing the env var, fzf reads it again, causing --height (CLI) to override --tmux (env) since CLI args take precedence over FZF_DEFAULT_OPTS.

Rewrite __fzf_defaults_nu to return a string (like bash's __fzf_defaults) instead of a list, and pass it via FZF_DEFAULT_OPTS with-env. This ensures --height has a lower index than --tmux from the user's FZF_DEFAULT_OPTS, so --tmux wins when both are present. Also fix a critical bug where the non-existent is-string command silently swallowed all options from FZF_DEFAULT_OPTS.

These tests were identical to the ones inherited from TestShell via include, so the redefinitions were unnecessary.

sim590 · 2026-04-23T22:01:23Z

Thanks for testing! Here's a summary of the fixes:

pass crash: Fixed in 8057be90 — added try/catch so pass **<TAB> no longer errors when ~/.password-store doesn't exist.
Multi-selection: Fixed in e127c4ef — selected paths are now joined with lines | str join ' ' instead of being returned as separate entries.
--tmux in FZF_DEFAULT_OPTS: Fixed in 0025d228 — __fzf_defaults_nu now builds FZF_DEFAULT_OPTS as a string (like bash's __fzf_defaults), so --tmux takes precedence over --height. The root cause was twofold: (1) is-string doesn't exist in Nushell, so a filter was silently dropping all FZF_DEFAULT_OPTS entries, and (2) --height was passed as a CLI argument (higher index) instead of through FZF_DEFAULT_OPTS (where --tmux could override it).

Remove test_ctrl_r which was identical to the inherited TestShell version. Add comments explaining why the remaining overrides are necessary: - test_ctrl_t_unicode: uses ^echo (external) instead of echo - test_file_completion: single-selection only (completer replaces token) - test_ctrl_r_abort: skips quote characters that break Nushell

junegunn · 2026-04-24T01:51:12Z

Coding agents can miss subtle issues that only surface in hands-on use, which matters a lot for an interactive tool like fzf. Could you share a list of what you manually tested, ideally with screenshots?

Nushell passes ~/path to the external completer with the tilde unexpanded. Expand it with 'path expand' before passing it to fzf as --walker-root, and restore the tilde prefix in the result.

…letion Cover multi-selection (Tab+Tab), single selection, and hidden files. Previously only single selection was tested, which let the multi-selection bug slip through unnoticed.

sim590 · 2026-04-24T03:15:58Z

Coding agents can miss subtle issues that only surface in hands-on use, which matters a lot for an interactive tool like fzf.

Yes. I agree.

Could you share a list of what you manually tested, ideally with screenshots?

I tested:

all keybindings
vim **<TAB>
- with no prefix.
- with absolute path prefix
- with relative path prefix
- with ~
- with $env.HOME/**, but that doesn't work. I think that this is a limitation of Nushell's completion dipatcher
^cd **<TAB>
^kill **<TAB>
pass **<TAB>
pacman -S **<TAB>
pacman -Q **<TAB>

All of these work as expected. Here are some screenshots...

vim and ctrl+t:

junegunn · 2026-04-24T05:17:14Z

+- Custom completion extensibility (e.g. `_fzf_complete_COMMAND` in bash/zsh)
+  is not available. Custom completions are defined via a `match` statement
+  in `completion.nu`.


Would it be possible to implement this scheme? A hard-coded match statement feels quite limiting. It could easily turn into a "kitchen sink", with users continually requesting more commands to be added.

For what it's worth, I'm on macOS and don't use tools like pacman or pass, so having them in the default list feels a bit off. I imagine this concern will only grow as more items get added over time.

imsys and others added 30 commits May 4, 2025 04:58

A Nushell partial support test

5aa22d4

Some efforts to get it working

79eab96

Almost working

64d5ace

somewhat working

6011574

seems to be working

785bc07

lower case tab

30d1d45

different implementation approach: External Completers

a4ef417

fixes fzf custom height

5236752

Nushell - fzf uses realative path

4b8fef0

nushell - layout reverse

3bd895c

nushell: fixes ssh completion

15314f4

Nushell: refactoring

b2b25b2

Nushell: makes the code of both options similar.

e4ceecb

Fixes some path issues. There are still some other things to fix

removing debug print

3e0d3a8

Nushell: seems to be the final fix for path issues

da97e61

cleanup and kill completion

20bb07c

Nushell: prepend binding instead of appending

c39e328

Nushell: Another alternative implementation, but using nushell menu

bde90bc

Nushell: notes

456cf2a

renames completion.nu to completion-bind.nu

6289a28

Nushell: notes

77d0b56

Nushell: minor grammar/spelling

d1a6120

fix typo

1f66d6e

completion-external: add pass completion

7ec4d98

Pass~[1] is a command line password storage utility. Possible queries are deduced from the file GPG hierarchy under ~/.password-store. [1]: https://www.passwordstore.org/

completion-external: use type "any" for optional closure

95f636f

completion-external: use flag for _fzf_complete_nu's post_process_clo…

e9ac742

…sure parameter

completion-external: remove bad "return" calls

8c2183d

Not sure why it doesn't work in this context, but if those are not removed, the completion process doesn't substitute the selected value to '**'.

completion-external: remove unused input_line_before_trigger parameter

90d2331

completion-external: fix alignement

ef66bd7

Merge pull request #1 from zalewskigrzegorz/fix/nushel-scipt-typo

535ff16

fix typo shell/key-bindinds.nu → shell/key-bindings.nu

junegunn reviewed Apr 22, 2026

View reviewed changes

Comment thread README.md Outdated

Copilot AI reviewed Apr 22, 2026

View reviewed changes

sim590 added 2 commits April 22, 2026 10:49

docs: rewrite nushell setup to use native syntax

691dfa3

Replace the confusing 'run this in your regular shell' comment with a pure Nushell command using 'save -f'.

docs: remove --nushell from version note

305a650

The note references fzf 0.48.0 which only introduced --bash, --zsh, and --fish. The --nushell flag will be available in a later release.

junegunn reviewed Apr 23, 2026

View reviewed changes

Comment thread README.md

docs: simplify version note and create autoload dir

adbd8e7

Use 'recent versions of fzf' instead of a specific version number as suggested by junegunn. Also add mkdir before save to handle the case where the autoload directory does not exist yet.

sim590 force-pushed the nushell-integration branch 2 times, most recently from f154fa3 to adbd8e7 Compare April 23, 2026 07:04

junegunn requested changes Apr 23, 2026

View reviewed changes

docs: add nushell example for disabling keybindings

a56922c

junegunn reviewed Apr 23, 2026

View reviewed changes

Comment thread README.md Outdated

sim590 added 6 commits April 23, 2026 16:43

fix(nushell): handle missing password store in pass completion

8057be9

Wrap the ls glob in a try/catch so that pass completion returns an empty list instead of a verbose error when ~/.password-store does not exist.

fix(nushell): join multi-selected paths into single completion result

e127c4e

When multiple files are selected with Tab in fzf, join them with spaces so the completer returns a single result instead of separate candidates displayed with ::: separators.

fix(readme): use -- instead of em dash for Nushell bullet

ddf7025

refactor(test): remove redundant test_ctrl_t and test_alt_c_command

1901af7

These tests were identical to the ones inherited from TestShell via include, so the redefinitions were unnecessary.

junegunn reviewed Apr 24, 2026

View reviewed changes

Comment thread test/test_shell_integration.rb Outdated

fix(completion): expand tilde in walker-root for path completion

b4e1992

Nushell passes ~/path to the external completer with the tilde unexpanded. Expand it with 'path expand' before passing it to fzf as --walker-root, and restore the tilde prefix in the result.

sim590 force-pushed the nushell-integration branch from 54c2615 to b4e1992 Compare April 24, 2026 02:31

sim590 added 2 commits April 23, 2026 23:01

fix(test): replace em-dash with ASCII double dash

6f1ed5a

test(nushell): add multi-selection and hidden files to test_file_comp…

4ec77b9

…letion Cover multi-selection (Tab+Tab), single selection, and hidden files. Previously only single selection was tested, which let the multi-selection bug slip through unnoticed.

junegunn reviewed Apr 24, 2026

View reviewed changes

		# Assuming standard ps output where PID is the second column
		$selected_line \| lines \| each { $in \| from ssv --noheaders \| get 0.column1 } \| to text

Uh oh!

Conversation

sim590 commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

sim590 Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

junegunn Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

sim590 Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

junegunn Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

sim590 Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

junegunn Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sim590 Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

junegunn commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

junegunn commented Apr 23, 2026

Uh oh!

Uh oh!

junegunn commented Apr 23, 2026

Uh oh!

sim590 commented Apr 23, 2026

Uh oh!

Uh oh!

junegunn commented Apr 24, 2026

Uh oh!

sim590 commented Apr 24, 2026

Uh oh!

junegunn Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sim590 commented Dec 9, 2025 •

edited

Loading

junegunn Apr 24, 2026 •

edited

Loading

junegunn commented Apr 23, 2026 •

edited

Loading